Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parachain availability store #1333

Merged
merged 2 commits into from
Sep 12, 2022
Merged

parachain availability store #1333

merged 2 commits into from
Sep 12, 2022

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Sep 7, 2022

Referenced issues

Description of the Change

Add availability store interface.

Benefits

  • Store chunks, pov and data.
  • Interface will be used by multiple components (candidate backing, availability distribution, ...).

Possible Drawbacks

  • Implement pruning later.

Usage Examples or Tests

Alternate Designs

  • Will read/write database later.

@turuslan turuslan requested a review from iceseer September 7, 2022 15:02
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #1333 (ee39702) into master (0c3398f) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1333      +/-   ##
==========================================
- Coverage   25.00%   24.93%   -0.07%     
==========================================
  Files         610      612       +2     
  Lines       22553    22588      +35     
  Branches    11779    11794      +15     
==========================================
- Hits         5640     5633       -7     
- Misses      11705    11753      +48     
+ Partials     5208     5202       -6     
Impacted Files Coverage Δ
core/injector/application_injector.cpp 32.32% <ø> (ø)
core/parachain/availability/store/store_impl.cpp 0.00% <0.00%> (ø)
core/parachain/availability/store/store_impl.hpp 0.00% <0.00%> (ø)
core/metrics/impl/session_impl.cpp 37.50% <0.00%> (-8.34%) ⬇️
core/api/transport/impl/ws/ws_listener_impl.cpp 40.27% <0.00%> (-2.78%) ⬇️
core/metrics/impl/prometheus/handler_impl.cpp 26.53% <0.00%> (-2.05%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@turuslan turuslan requested a review from ortyomka September 8, 2022 07:18
@turuslan turuslan force-pushed the parachain/availability-store branch from 46a8e40 to 22dda6c Compare September 9, 2022 11:51
@turuslan turuslan requested a review from iceseer September 9, 2022 11:51
@turuslan turuslan enabled auto-merge (squash) September 12, 2022 08:02
@turuslan turuslan merged commit fc8d3d5 into master Sep 12, 2022
@turuslan turuslan deleted the parachain/availability-store branch September 12, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants