Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save lp2p key #1301

Merged
merged 6 commits into from
Sep 1, 2022
Merged

Save lp2p key #1301

merged 6 commits into from
Sep 1, 2022

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Aug 4, 2022

Referenced issues

#1072

Description of the Change

Try to save generated lp2p key if --save-node-key.

Benefits

Peer id preserved across restarts.

Possible Drawbacks

Usage Examples or Tests

Alternate Designs

Signed-off-by: turuslan <[email protected]>
@turuslan turuslan marked this pull request as ready for review August 4, 2022 08:43
@turuslan turuslan requested review from xDimon and GaroRobe August 4, 2022 08:44
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #1301 (0f45076) into master (8d57222) will decrease coverage by 0.01%.
The diff coverage is 9.61%.

@@            Coverage Diff             @@
##           master    #1301      +/-   ##
==========================================
- Coverage   25.29%   25.27%   -0.02%     
==========================================
  Files         605      606       +1     
  Lines       21902    21910       +8     
  Branches    11359    11368       +9     
==========================================
- Hits         5540     5538       -2     
- Misses      11242    11251       +9     
- Partials     5120     5121       +1     
Impacted Files Coverage Δ
core/application/app_configuration.hpp 100.00% <ø> (ø)
core/application/impl/app_configuration_impl.cpp 23.93% <0.00%> (-0.08%) ⬇️
core/application/impl/app_configuration_impl.hpp 30.00% <0.00%> (-0.89%) ⬇️
core/crypto/crypto_store/crypto_store_impl.hpp 37.77% <ø> (ø)
core/injector/get_peer_keypair.hpp 6.97% <6.97%> (ø)
core/injector/application_injector.cpp 34.58% <25.00%> (+1.36%) ⬆️
core/crypto/crypto_store/crypto_store_impl.cpp 24.82% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@turuslan turuslan requested a review from kamilsa August 31, 2022 10:39
@turuslan turuslan enabled auto-merge (squash) August 31, 2022 10:41
@turuslan turuslan disabled auto-merge August 31, 2022 11:15
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
@turuslan turuslan requested a review from Harrm August 31, 2022 12:02
@turuslan turuslan merged commit 9a8e31c into master Sep 1, 2022
@turuslan turuslan deleted the save-lp2p-key-1072 branch September 1, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants