Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: drop python 3.8 support, update type hints, ci #403

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

joein
Copy link
Member

@joein joein commented Nov 15, 2024

Python3.8 reached it's end of life October 7th, this PR drops it support, and replaces type hins like typing.List, typing.Dict with the builtin structures e.g. list and dict

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@Anush008 Anush008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@joein joein merged commit 1343e55 into main Nov 15, 2024
14 checks passed
@joein joein deleted the drop-python-3.8 branch November 15, 2024 14:54
@I8dNLo I8dNLo mentioned this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants