Bm25 multilanguage #318
Merged
Bm25 multilanguage #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # fastembed/image/onnx_image_model.py # tests/test_image_onnx_embeddings.py
joein
requested changes
Aug 6, 2024
joein
requested changes
Aug 8, 2024
tests/test_attention_embeddings.py
Outdated
| docs = ["Mangez-vous vraiment des grenouilles?", "Je suis au lit"] | ||
|
|
||
| model = SparseTextEmbedding(model_name=model_name, language="french") | ||
| embeddings = list(model.embed(docs, parallel=2))[:2] |
There was a problem hiding this comment.
Suggested change
| embeddings = list(model.embed(docs, parallel=2))[:2] | |
| embeddings = list(model.embed(docs))[:2] |
There was a problem hiding this comment.
we've already tested parallel above, i think it's better to keep this test simpler and check only one thing
joein
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support of multilanguages stopwords for bm25
Mere refactoring of bm25
Tests for multilanguages