Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiniLM fix #275

Merged
merged 4 commits into from
Jun 14, 2024
Merged

MiniLM fix #275

merged 4 commits into from
Jun 14, 2024

Conversation

I8dNLo
Copy link
Contributor

@I8dNLo I8dNLo commented Jun 13, 2024

MiniLM fix.
Now it uses official implementation and pooling from SM repo

@I8dNLo I8dNLo requested a review from joein June 13, 2024 23:45
Fixed MiniLM source destination
Black + isort for repo
Copy link
Member

@joein joein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better not to mix style refactoring + actual code changes in one PR, because it becomes more difficult to review.
It might be ok to combine them in one PR once the code changes are approved

d.rudenko and others added 2 commits June 14, 2024 15:08
@I8dNLo I8dNLo requested a review from joein June 14, 2024 12:40
@I8dNLo I8dNLo merged commit 3312079 into qdrant:main Jun 14, 2024
15 checks passed
Anush008 pushed a commit that referenced this pull request Jun 17, 2024
* MiniLM fix

* Added MiniLM to text embedding
Fixed MiniLM source destination
Black + isort for repo

* Fixed model all-MiniLM-L6-v2 description
Recomputed canonical vector for all-MiniLM-L6-v2 in test

---------

Co-authored-by: d.rudenko <[email protected]>
@michaelfeil
Copy link

Awesome! @I8dNLo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants