Replace Data Source #206
Merged
Replace Data Source #206
+236
−239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
there is a magic integer (3072), it should better be replaced with a constant |
joein
requested changes
Apr 29, 2024
There was a problem hiding this comment.
Downloading process works
Binary quantization from scratch :
- mean accuracy is called recall in the results
- Binary conversion section is repeated 3 times
Binary quantization with qdrant :
- Quantization does not work in local mode
- on_disk does not work in local mode
- oversampling = 1.0 is not really useful with the current logic, since it won't bring any new vectors (but just sort already retrieved ones) and the order does not matter with the chosen metric
joein
approved these changes
Jun 6, 2024
Anush008
pushed a commit
that referenced
this pull request
Jun 17, 2024
* Re-run of identical hardware and generate graphs * Re-run of identical hardware and generate graphs Fixes #174 * Change dataset source * Refactor code for better readability and maintainability * Inline outputs * Replace hard coded constants with dataset specific n_dim * fix: fix binary quant from scratch notebook * fix: fix result table, explain corner case --------- Co-authored-by: George Panchuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #174