Require Python 3.10 and Sphinx 7.3 #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
reviewed
Feb 3, 2025
There was a problem hiding this comment.
(There's a conflict after merging #219.)
Looking good, although before merging and pinning 3.11 to 2024.12 in python/cpython#129576, it might be nice to get #218 merged and released in 2025.2, and then pinning 3.11 to 2025.2?
Merged
# Conflicts: # python_docs_theme/__init__.py # python_docs_theme/static/pydoctheme.css
|
3.10 & 3.11 are now pinned to 2025.2, so merging this. A |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also python/cpython#129576. This would mean this theme is no longer installable with the 3.10 or 3.11 branches, which require
sphinx==3.4.3andsphinx~=7.2.0respectively.Changes:
_add_asset_hashespatchsidebar.js_tfor Sphinx 4.xsetup()theme.confto the newtheme.toml(viapython -m sphinx.theming conf_to_toml python_docs_theme)versionextension metadata field.@import url(...)with an entry in thesidebarslist, to allow parallel stylesheet fetching by the user agentA
📚 Documentation preview 📚: https://python-docs-theme-previews--221.org.readthedocs.build/