Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "slave" -> "worker" for xdist compatibility #307

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

Zac-HD
Copy link
Member

@Zac-HD Zac-HD commented Jun 14, 2020

Fixes #305, cc @nicoddemus.

Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely

@Zac-HD
Copy link
Member Author

Zac-HD commented Jun 18, 2020

@BeyondEvil - can you merge and release this soon? I'd like to have it out to users before we do the xdist break, so there's no gap in compatibility where the latest versions don't work togther 🙂

Copy link
Contributor

@BeyondEvil BeyondEvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 💪

@@ -7,6 +7,10 @@ Release Notes

* Thanks to `@p00j4 <https://github.com/p00j4>`_ and `@anothermattbrown <https://github.com/anothermattbrown>`_ for reporting and `@christiansandberg <https://github.com/christiansandberg>`_ and `@superdodd <https://github.com/superdodd>`_ and `@dhalperi <https://github.com/dhalperi>`_ for the fix

* Fix attribute name for compatibility with ``pytest-xdist`` 2. (`#305 <https://github.com/pytest-dev/pytest-html/issues/305>`_)

* Thanks to `@Zac-HD <https://github.com/Zac-HD>`_ for the fix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See, that's what I want to see for base-url as well 😉

@BeyondEvil BeyondEvil merged commit b5a02fb into pytest-dev:master Jun 18, 2020
@ssbarnea ssbarnea added the bug This issue/PR relates to a bug. label Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upcoming incompatibility in pytest-xdist 2.0: "slave" aliases removed
4 participants