Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle when report title is stored as an environment variable #203

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

BeyondEvil
Copy link
Contributor

When the --html flag is used in pytest.ini with "addopts" and the
report title is stored in an environment variable, the name of the
environment variable was used as the report title.

In other words, the environment variable was never expanded.

Fixes: #201

When the --html flag is used in pytest.ini with "addopts" and the
report title is stored in an environment variable, the name of the
environment variable was used as the report title.

In other words, the environment variable was never expanded.

Fixes: pytest-dev#201
@BeyondEvil BeyondEvil added the bug This issue/PR relates to a bug. label Apr 26, 2019
@BeyondEvil BeyondEvil self-assigned this Apr 26, 2019
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 👍

@BeyondEvil BeyondEvil merged commit 67dc737 into pytest-dev:master Apr 26, 2019
@BeyondEvil BeyondEvil deleted the handle-env-var-in-addopts branch August 6, 2019 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page header does not take environment variables into account
2 participants