-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packaging infrastructure #1906
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm wondering if we should update our development status to "Production/Stable" in pyproject.toml but that's probably a discussion for another time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! i'm going to borrow some of those tomllib
tricks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kbwestfall
#!/usr/bin/env python | ||
|
||
""" | ||
Check that the installation of python is C enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to change this description
Updates the packaging approach to remove the
setup.cfg
file and use only thepyproject.toml
file. We still require thesetup.py
file to build the C components of the code.This also updates the development doc to reflect these (and a few other) changes.
Note this is currently a PR into the branch that removes the
misc
directories that have now been moved to their own repository.