Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: Add DownloadFile function #790

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ahmad-abuziad
Copy link

Enhancement

  • automatically create directories if don't exist, now it fails if any directory doesn't exist in the filePath
  • if filePath is empty string, create a file with random name under tmp directory and return a string(path to the file)
  • parameter named to filePath with capital P to avoid confusion with the filepath package

@ahmad-abuziad ahmad-abuziad changed the title utl: add DownloadFile function util: add DownloadFile function Feb 10, 2025
@ahmad-abuziad ahmad-abuziad force-pushed the http-download-resource branch 2 times, most recently from ed9faed to 08cf287 Compare February 11, 2025 14:39
@ahmad-abuziad ahmad-abuziad changed the title util: add DownloadFile function util: Add DownloadFile function Feb 11, 2025
@ahmad-abuziad ahmad-abuziad marked this pull request as ready for review February 11, 2025 14:40
@ahmad-abuziad ahmad-abuziad marked this pull request as draft February 11, 2025 14:43
@ahmad-abuziad ahmad-abuziad marked this pull request as ready for review February 11, 2025 15:01
@ahmad-abuziad
Copy link
Author

@purpleidea please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant