Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Load libxcb.so if the main library doesn't load #787

Closed
wants to merge 1 commit into from
Closed

bugfix: Load libxcb.so if the main library doesn't load #787

wants to merge 1 commit into from

Conversation

notgull
Copy link
Collaborator

@notgull notgull commented Jan 2, 2023

Closes #785

@ids1024 Could you verify that this branch works on NetBSD?

@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Base: 13.70% // Head: 13.70% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (f5ae460) compared to base (c8b4c9b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
- Coverage   13.70%   13.70%   -0.01%     
==========================================
  Files         142      142              
  Lines      120070   120083      +13     
==========================================
  Hits        16454    16454              
- Misses     103616   103629      +13     
Flag Coverage Δ
tests 13.70% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
x11rb/src/xcb_ffi/raw_ffi/ffi.rs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@psychon psychon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm rejecting this as Eduardo seems to agree that this should be properly figured out first. But thanks for turning my rambling into a PR.

@notgull notgull closed this Jan 2, 2023
@notgull notgull deleted the netbsd branch January 2, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to find libxcb on NetBSD
2 participants