Skip to content
This repository was archived by the owner on Aug 29, 2023. It is now read-only.

Update to go 1.18 #307

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Update to go 1.18 #307

merged 1 commit into from
Mar 21, 2022

Conversation

laurentsenta
Copy link
Contributor

@laurentsenta laurentsenta commented Mar 18, 2022

Closes #193

Todo:

@laurentsenta laurentsenta marked this pull request as draft March 18, 2022 16:03
@marten-seemann
Copy link
Contributor

I realize this is a PR targeting next, so this doesn't need to go into this PR. Just wanted to raise that we probably also want to update staticcheck (and check if there'll be a new release for Go 1.18) before running the deployment to all repos.

@galargh galargh mentioned this pull request Mar 21, 2022
1 task
@galargh
Copy link
Contributor

galargh commented Mar 21, 2022

I accidentally created a duplicate of this in #308.

Reposting the comment from @mvdan on staticcheck:

I don't think we need to block adding Go 1.18 until the next staticcheck version is out. The main reason that staticcheck is broken with 1.18 is due to generics, but the vast majority of repos using unified CI will keep on supporting Go 1.17, meaning they generally can't use generics yet, unless they go for some funky business with //go:build go1.18.

This assumes that it will be painless to update staticcheck in a week's time once they do release proper support for Go 1.18, though. I assume that for most repos it would be a bit bothersome to merge the update to Go 1.18 this week, and a staticcheck update next week. For that reason, it might be best to wait a week until we deploy the Go 1.18 update.

Here's the staticcheck issue that track new version release progress: dominikh/go-tools#1166

Reposting the comment from me on next major unified CI release:

I'd really appreciate if we could do the next major unified CI release with #261 because it'd give us a chance that the release process itself succeeds without human intervention.

Reposting the section on testing I did with the exact same test set:

Updated .github-test-target in protocol/.github-test-target#37 (this also showcases the staticcheck issue)

@galargh galargh marked this pull request as ready for review March 21, 2022 13:38
@galargh
Copy link
Contributor

galargh commented Mar 21, 2022

I agree with Daniel on staticcheck, it'd be less noisy to wait for a week for that new staticcheck version.

And with Marten as well, we don't have to wait with merging this PR until staticcheck business is sorted out.

@galargh galargh merged commit efdc0be into next Mar 21, 2022
@galargh galargh deleted the feat/go118 branch March 21, 2022 17:56
galargh added a commit that referenced this pull request Apr 4, 2022
* Revert "include cross-package coverage in codecov"

* Revert "Revert "include cross-package coverage in codecov""

* Make automerge a reusable workflow (#260)

* move automerge from template to workflows

* make automerge reusable and use it from new automerge template

* pass parent job name to reusable automerge

* check github actions yamls (#272)

* check github actions yamls

* make yaml linter happy about go-test

* mention VS Code YAML extension in the readme

* add info about other YAML checking extensions

* make yaml checker more generic

* use validate-yaml-schema action from mainline (#277)

* upgrade lewagon/wait-on-check-action to v1.1.1 (#278)

* always add a version.json file if it doesn't exist (#281)

* fix go-test runner string

* check if tag already exists in release-check (#287)

* allow specifying custom PATH for 386 arch (#289)

* go: update to 1.18.x (#307)

* Upgrade staticcheck to v0.3.0 (#311)

* increase sleep between PR creations to 10s

* restore DEFAULT_BRANCH replacement

Co-authored-by: Laurent Senta <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants