Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jspecify Nonnull/Nullable annotations #3837

Closed

Conversation

moonfruit
Copy link
Contributor

The spring-framework has now abandoned its own definition of Nonnull/Nullable annotations in favor of those defined by jspecify.
As one of the most successful Java open source project, I'm sure more and more people will follow it and start using jspecify.
So I think it's important for lombok to provide predefined configuration templates for jspecify to simplify its use.

Copy link
Collaborator

@Rawi01 Rawi01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 👍

  • Please update the comment in ConfigurationKeys and the documentation in configuration.html to include the new key
  • Please add yourself to the AUTHORS file

@moonfruit moonfruit force-pushed the null-library-jspecify branch from 979c572 to df98ac2 Compare March 11, 2025 03:24
@moonfruit
Copy link
Contributor Author

OK. I'm done. Please help me check if there are any more changes that need to be made.

@moonfruit moonfruit requested a review from Rawi01 March 11, 2025 03:29
@knutwannheden
Copy link

At some point it would be awesome if Lombok could support scoped annotations like JSpecify's @NullMarked. Without that I doubt that Lombok will be able to leverage JSpecify very much.

@rzwitserloot
Copy link
Collaborator

This has been merged as commit 0d0aba6. Not quite sure why github hasn't picked up on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants