Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the CSS modules feature flag from the Hidden component #5683

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

jonrohan
Copy link
Member

The Hidden component has no uses in dotcom so I thought I would skip past to the end for this component.

Changelog

New

Changed

Removed

CSS modules feature flag, fully converting to CSS modules

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jonrohan jonrohan requested a review from a team as a code owner February 10, 2025 20:22
@jonrohan jonrohan requested a review from langermank February 10, 2025 20:22
Copy link

changeset-bot bot commented Feb 10, 2025

🦋 Changeset detected

Latest commit: 910272d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Feb 10, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 10, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Feb 10, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.53 KB (0%)
packages/react/dist/browser.umd.js 105.9 KB (0%)

@github-actions github-actions bot requested a deployment to storybook-preview-5683 February 10, 2025 20:26 Abandoned
@github-actions github-actions bot requested a deployment to storybook-preview-5683 February 10, 2025 20:30 Abandoned
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/361744

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Feb 10, 2025
@jonrohan jonrohan requested a review from joshblack February 10, 2025 22:00
@jonrohan jonrohan added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit 8bb78e1 Feb 10, 2025
44 checks passed
@jonrohan jonrohan deleted the remove_css_modules_feature_flag_hidden branch February 10, 2025 22:14
@primer primer bot mentioned this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants