Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: migrate from Travis CI to GitHub Actions and polish ansible-lint configuration #36

Merged
merged 7 commits into from
Mar 17, 2023
Merged

ci: migrate from Travis CI to GitHub Actions and polish ansible-lint configuration #36

merged 7 commits into from
Mar 17, 2023

Conversation

MikkCZ
Copy link
Contributor

@MikkCZ MikkCZ commented Mar 12, 2023

No description provided.

@MikkCZ MikkCZ changed the title test" migrate from Travis CI to GitHub Actions and polish ansible-lint configuration test: migrate from Travis CI to GitHub Actions and polish ansible-lint configuration Mar 12, 2023
@MikkCZ MikkCZ changed the title test: migrate from Travis CI to GitHub Actions and polish ansible-lint configuration ci: migrate from Travis CI to GitHub Actions and polish ansible-lint configuration Mar 12, 2023
@rixx
Copy link
Member

rixx commented Mar 13, 2023

I don't think we need a build matrix here – testing with a single Python version (3.11, I should think) is absolutely sufficient.

(Also, for future reference, when you want to use Python 3.10 in YAML files like that, you have to make it a string, as otherwise YAML will parse it as a number and Python 3.1 is a long time in our past, thankfully.)

Copy link
Member

@rixx rixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@MikkCZ
Copy link
Contributor Author

MikkCZ commented Mar 13, 2023

I don't think we need a build matrix here – testing with a single Python version (3.11, I should think) is absolutely sufficient.

(Also, for future reference, when you want to use Python 3.10 in YAML files like that, you have to make it a string, as otherwise YAML will parse it as a number and Python 3.1 is a long time in our past, thankfully.)

Thanks, updated.

@MikkCZ
Copy link
Contributor Author

MikkCZ commented Mar 13, 2023

I also fixed a couple of errors reported by ansible-lint in the latest version. It still complains about latest being used for packages installed for Arch. For Debian this was addressed in #35, but I am not familiar with Arch and what is the expected behavior for updates there?

@MikkCZ MikkCZ requested a review from rixx March 13, 2023 17:14
Copy link
Member

@rixx rixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@rixx
Copy link
Member

rixx commented Mar 17, 2023

I'm honestly not sure what to do about Arch here – probably best to listen to the linter, but I can do that post-merge.

@rixx rixx merged commit 7d0e0d6 into pretalx:master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants