Hydrationfix #957
Merged
Hydrationfix #957
+382
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developit
reviewed
Jan 29, 2020
| const { existsSync } = require('fs'); | ||
|
|
||
| function isInstalledVersionPreactXOrAbove(cwd) { | ||
| const pathToPreact = resolve(cwd, 'node_modules', 'preact'); |
There was a problem hiding this comment.
I wonder if it'd be worth using require.resolve here?
Suggested change
| const pathToPreact = resolve(cwd, 'node_modules', 'preact'); | |
| let pathToPreact; | |
| try { | |
| pathToPreact = path.dirname(require.resolve('preact/package.json')); | |
| } | |
| catch (e) {} |
With this change the whole function could be this:
const resolveFrom = require('resolve-from');
function isInstalledVersionPreactXOrAbove(cwd) {
try {
return parseInt(require(resolveFrom(cwd, 'preact/package.json')), 10) >= 10;
}
catch (e) {}
return false;
}| const pathToPackage = resolve(pathToPreact, 'package.json'); | ||
| const { version: preactVersionString } = require(pathToPackage); | ||
| return ( | ||
| parseInt(preactVersionString.substr(0, preactVersionString.indexOf('.'))) >= |
There was a problem hiding this comment.
parseInt() parses the first integer so it'll already return only the major:
Suggested change
| parseInt(preactVersionString.substr(0, preactVersionString.indexOf('.'))) >= | |
| parseInt(preactVersionString, 10) >= |
| const old = root.removeChild; | ||
| root.removeChild = child => { | ||
| window.ROOT_MUTATION_COUNT++; | ||
| old(child); |
There was a problem hiding this comment.
this would throw (thankfully it's not being called! haha)
Suggested change
| old(child); | |
| old.call(this, child); |
developit
approved these changes
Jan 29, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
Yes
Summary
Does this PR introduce a breaking change?
No