-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.8 support #6856
base: main
Are you sure you want to change the base?
Drop Python 3.8 support #6856
Conversation
E2E Tests 🚀 |
I'm happy to consider small refinements to this PR based on Austin's feature spec but don't want the scope to creep too much – unless someone else is able to look into the additional work and we're able to sequence it appropriately. This PR is also a blocker to #6855 which is targeted for this milestone. |
@@ -117,7 +117,7 @@ jobs: | |||
matrix: | |||
os: [ubuntu-latest] | |||
# Run the tests on the oldest and most recent versions of Python. | |||
python: ['3.8', '3.13'] | |||
python: ['3.9', '3.13'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we change nightly to only 3.9+ as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, done in 0453138
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(putting these comments on a diff somewhere so they can be threaded)
I found some other places where we refer to python < 3.9, that you can probably simplify now:
positron/extensions/positron-python/python_files/posit/positron/tests/test_ui.py
Line 239 in 2a33b2f
@pytest.mark.skipif(sys.version_info < (3, 9), reason="requires Python 3.9 or higher") |
polars[timezone]; python_version < '3.9' or sys_platform == 'win32' |
# as is from < Python 3.9, since 3.9 introduces a breaking change to pydoc.getdoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to consider small refinements to this PR based on Austin's feature spec but don't want the scope to creep too much
Yeah, the only thing to call out is that people using 3.8 who update Positron might see some confusing behavior where if they switch away from their interpreter, they won't be able to switch back. I think that's fine for now. In my spec I'm proposing that we're a little more transparent about unsupported versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about it some more and I think we should delay the jedi-language-server upgrade to the next milestone, and that we should consider implementing some of your suggestions. For the reason you mentioned as well as that I'd want more time for us to have the jedi changes in daily builds before it goes live. Let's discuss with everyone in the next sync about prioritizing some of the low hanging work for unsupported version UX.
Addresses #6811. This doesn't really fit the feature/bug fix classification but I decided to go with bug fix.
Release Notes
New Features
Bug Fixes
QA Notes
It shouldn't be possible to start a Python 3.8 session in Positron. Everything else should continue to work as is.