Fix race condition in epoll ASIO system #4658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The removed code was accessing an event that was also being modified from other threads. In particular, by the TCP Connection actor that the event belonged to (only TCPConnection currently uses one-shot events). This could lead to all the hilarity that one can expect from things. Closes #4639
ponylang-main
added
the
discuss during sync
SeanTAllen
added
changelog - fixed
|
This has been run through the linux tcp open close stress tests 5 times. |
ponylang-main
added
the
discuss during sync
dipinhora
approved these changes
Mar 7, 2025
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed code was accessing an event that was also being modified from other threads. In particular, by the TCP Connection actor that the event belonged to (only TCPConnection currently uses one-shot events).
This could lead to all the hilarity that one can expect from things.
Closes #4639