Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure systematic testing doesn't switch to suspended thread #4647

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

dipinhora
Copy link
Contributor

Prior to this commit, the systematic testing next thread logic would consider switching to the pinned actor thread even if it was suspended. This was very wasteful since the suspended pinned actor thread would not do any meaningful work and almost immediately re-suspend itself.

This commit changes things so that the next thread logic properly takes into account whether the pinned actor thread is suspended or not when selecting the next thread to activate.

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Mar 4, 2025
@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Mar 4, 2025
@ponylang-main
Copy link
Contributor

Hi @dipinhora,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 4647.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen
Copy link
Member

@dipinhora can you rebase against main?

Prior to this commit, the systematic testing next thread logic
would consider switching to the pinned actor thread even if it
was suspended. This was very wasteful since the suspended pinned
actor thread would not do any meaningful work and almost immediately
re-suspend itself.

This commit changes things so that the next thread logic properly
takes into account whether the pinned actor thread is suspended
or not when selecting the next thread to activate.
@dipinhora
Copy link
Contributor Author

@dipinhora can you rebase against main?

i didded it

@SeanTAllen SeanTAllen merged commit df4cf17 into ponylang:main Mar 5, 2025
22 checks passed
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants