Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak #4621

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Fix memory leak #4621

merged 1 commit into from
Feb 20, 2025

Conversation

SeanTAllen
Copy link
Member

This reverts commit b5decba.

The fix of a theoretical use after free (which is currently not actually an issue) is causing a very real world explosion in memory usage for some programs.

@SeanTAllen SeanTAllen requested a review from dipinhora February 20, 2025 13:29
@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Feb 20, 2025
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Feb 20, 2025
@ponylang-main
Copy link
Contributor

Hi @SeanTAllen,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 4621.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen SeanTAllen force-pushed the revert-4541 branch 2 times, most recently from 850e31f to 40ff42b Compare February 20, 2025 13:40
@SeanTAllen SeanTAllen changed the title Revert "Fix mpmcq use-after-free bug (#4541)" Fix memory leak Feb 20, 2025
This reverts commit b5decba.

The fix of a theoretical use after free (which is currently not
actually an issue) is causing a very real world explosion in
memory usage for some programs.
@SeanTAllen SeanTAllen marked this pull request as ready for review February 20, 2025 16:53
@SeanTAllen SeanTAllen merged commit 0bb83e2 into main Feb 20, 2025
28 checks passed
@SeanTAllen SeanTAllen deleted the revert-4541 branch February 20, 2025 16:54
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Feb 20, 2025
github-actions bot pushed a commit that referenced this pull request Feb 20, 2025
github-actions bot pushed a commit that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants