Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect printing of runtime stats #4620

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Fix incorrect printing of runtime stats #4620

merged 1 commit into from
Feb 19, 2025

Conversation

SeanTAllen
Copy link
Member

@SeanTAllen SeanTAllen commented Feb 18, 2025

Some scheduler and actor runtime stat printing weren't properly gated by the "should print" check and thus would always print.

Closes #4619

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Feb 18, 2025
@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Feb 18, 2025
@ponylang-main
Copy link
Contributor

Hi @SeanTAllen,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 4620.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen SeanTAllen changed the title WIP Fix incorrect printing of runtime stats Feb 18, 2025
Some scheduler and actor runtime stat printing weren't properly
gated by the "should print" check and thus would always print.

Closes #4619
@SeanTAllen SeanTAllen marked this pull request as ready for review February 19, 2025 00:36
@SeanTAllen SeanTAllen requested a review from dipinhora February 19, 2025 00:36
@SeanTAllen SeanTAllen merged commit 95928dd into main Feb 19, 2025
28 checks passed
@SeanTAllen SeanTAllen deleted the 4619 branch February 19, 2025 02:50
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Feb 19, 2025
github-actions bot pushed a commit that referenced this pull request Feb 19, 2025
github-actions bot pushed a commit that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppressing the output from runtimestats
3 participants