Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure scheduler threads don't ACK the quiescence protocol CNF messages if they have an actor waiting to be run #4583

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

dipinhora
Copy link
Contributor

@dipinhora dipinhora commented Jan 7, 2025

Make sure scheduler threads don't ACK the quiescence protocol CNF messages if they have an actor waiting to be run.

Resolves #4582

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Jan 7, 2025
use @usleep[I32](micros: U32) if not windows
use @Sleep[None](millis: U32) if windows
use "actor_pinning"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whenever this is "done, can you add comments explaining the various bit that this is testing?

i think it will be non-obvious to many folks even if I understand.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the comment, perhaps we should call this regression-4582 ?

we have a number of full program tests with that naming scheme, named after the regression they are testing against.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@dipinhora dipinhora marked this pull request as ready for review January 7, 2025 23:00
@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Jan 8, 2025
@ponylang-main
Copy link
Contributor

Hi @dipinhora,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 4583.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen SeanTAllen changed the title actor pinning quiescence Make sure scheduler threads don't ACK the quiescence protocol CNF messages if they have an actor waiting to be run Jan 9, 2025
@SeanTAllen SeanTAllen merged commit 6db1561 into ponylang:main Jan 9, 2025
23 checks passed
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Jan 9, 2025
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quiescence issue with actor pinning
3 participants