-
-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure scheduler threads don't ACK the quiescence protocol CNF messages if they have an actor waiting to be run #4583
Conversation
7cf848c
to
fc4eff7
Compare
use @usleep[I32](micros: U32) if not windows | ||
use @Sleep[None](millis: U32) if windows | ||
use "actor_pinning" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whenever this is "done, can you add comments explaining the various bit that this is testing?
i think it will be non-obvious to many folks even if I understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from the comment, perhaps we should call this regression-4582 ?
we have a number of full program tests with that naming scheme, named after the regression they are testing against.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Hi @dipinhora, The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do. Release notes are added by creating a uniquely named file in the The basic format of the release notes (using markdown) should be:
Thanks. |
Make sure scheduler threads don't
ACK
the quiescence protocolCNF
messages if they have an actor waiting to be run.Resolves #4582