Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory errors with some --debug program builds #4372

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Fix memory errors with some --debug program builds #4372

merged 1 commit into from
Aug 16, 2023

Conversation

SeanTAllen
Copy link
Member

No description provided.

@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Aug 4, 2023
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Aug 4, 2023
@ponylang-main
Copy link
Contributor

Hi @SeanTAllen,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 4372.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen SeanTAllen added the do not merge This PR should not be merged at this time label Aug 9, 2023
@SeanTAllen SeanTAllen marked this pull request as ready for review August 15, 2023 21:28
@SeanTAllen SeanTAllen changed the title "Temporary" fix for segfault caused by exception code bug Fix memory errors with some --debug program builds Aug 15, 2023
@SeanTAllen SeanTAllen requested review from jemc and a team August 15, 2023 21:29
@SeanTAllen SeanTAllen removed the do not merge This PR should not be merged at this time label Aug 15, 2023
@SeanTAllen SeanTAllen force-pushed the 4369-temp branch 2 times, most recently from d4433d0 to 312a0d4 Compare August 15, 2023 22:25
@SeanTAllen
Fix memory errors with some --debug program builds
770ab56 
When we upgraded to LLVM 15, we accidentally changed our optimization
level for programs compiled with --debug. This uncovered a pre-existing
condition and caused issues like #4369.

This takes us back to LLVM 14 level but doesn't "fix" the underlying
issue which we are continuing to work on.
@SeanTAllen SeanTAllen merged commit d46f3f3 into main Aug 16, 2023
@SeanTAllen SeanTAllen deleted the 4369-temp branch August 16, 2023 15:53
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Aug 16, 2023
github-actions bot pushed a commit that referenced this pull request Aug 16, 2023
@ponylang-main
Updates release notes for PR #4372
e714357
github-actions bot pushed a commit that referenced this pull request Aug 16, 2023
@ponylang-main
Update CHANGELOG for PR #4372
09601f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemc jemc jemc approved these changes

Assignees
No one assigned
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeanTAllen @ponylang-main @jemc