Fix a possible resource leak with with blocks
#4347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanTAllen
added
the
changelog - changed
ponylang-main
added
the
discuss during sync
Previously, `with` blocks would allow the usage of `_` as a variable in the `with` parameters. A `_` variable isn't usable within the block itself and `dispose` wasn't called on the variable as it isn't valid to call any methods on the special `_` variable. The lack of `dispose` call on objects that might control resources could result in a resource leak. We've addressed the issue by disallowing `_` as a variable name in `with` parameters. This is a breaking change, albeit one we don't expect to have any "real-world" impact. Fixes #4345
jemc
reviewed
Apr 28, 2023
Co-authored-by: Joe Eli McIlvain <[email protected]>
jemc
approved these changes
Apr 28, 2023
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
withblocks would allow the usage of_as a variable in thewithparameters.A
_variable isn't usable within the block itself anddisposewasn't called on the variable as it isn't valid to call any methods on the special_variable.The lack of
disposecall on objects that might control resources could result in a resource leak.We've addressed the issue by disallowing
_as a variable name inwithparameters.This is a breaking change, albeit one we don't expect to have any "real-world" impact.
Fixes #4345