Don't allow FFI calls in default methods or behaviors #4065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponylang-main
added
the
discuss during sync
jemc
approved these changes
Mar 22, 2022
|
Looks good except for resolving the build failures. |
ponylang-main
added
the
discuss during sync
SeanTAllen
added
changelog - changed
ergl
force-pushed
the
ergl/no_ffi_in_default_methods
branch
from
1430ccc to
5f4ef07
Compare
|
This should get an update in the FFI section of the tutorial as well. |
ponylang-main
added
the
discuss during sync
|
@ergl this needs a rebase. |
ergl
force-pushed
the
ergl/no_ffi_in_default_methods
branch
from
05fb18d to
fea4c12
Compare
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3997, but not sure if this should have the "changed" or "fixed" label.