Fix the signature of Iter's map_stateful/map to not require ephemerals #4026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponylang-main
added
the
discuss during sync
jasoncarr0
changed the title
jasoncarr0
changed the title
|
There are some other possible changes we might want to make (filter_map can be a bit stronger likewise) but those would possibly be breaking changes, although one might argue that they are still fixes. |
jasoncarr0
added
the
changelog - fixed
SeanTAllen
reviewed
Feb 22, 2022
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a small stdlib issue discovered during: #4018
The signatures for map and map_stateful in itertools were overly strict, requiring
B^instead of justB, but only returnedIter[B]. Thus it had to be instantiated withiso^in some cases, exercising a bug with double ephemerals.This is not a breaking change.