Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LLVM to 13.0.1 #3994

Merged
merged 2 commits into from
Feb 5, 2022
Merged

Update LLVM to 13.0.1 #3994

merged 2 commits into from
Feb 5, 2022

Conversation

chalcolith
Copy link
Member

This change updates our LLVM submodule to llvmorg-13.0.1

@chalcolith chalcolith added the changelog - changed Automatically add "Changed" CHANGELOG entry on merge label Feb 4, 2022
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Feb 4, 2022
@ponylang-main
Copy link
Contributor

Hi @kulibali,

The changelog - changed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 3994.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen
Copy link
Member

Interesting: the identity_nested_tuple test failed on Windows.

@SeanTAllen
Copy link
Member

@kulibali did you rerun the failed Windows run?

@chalcolith
Copy link
Member Author

Yes.

@SeanTAllen
Copy link
Member

@kulibali it seems very odd to have that test be fail then not fail. Do you think it was a runner bug?

@chalcolith
Copy link
Member Author

It might have timed out for some reason.

@SeanTAllen
Copy link
Member

I don't see how. It's a very simple test in the middle of the runner suite.

@chalcolith
Copy link
Member Author

I observed during development that sometimes processes took a while to start on Windows, so my suspicion is that the compile and run steps might be taking too long for some Windows reason.

@SeanTAllen
Copy link
Member

Hmmm I've never seen before, so probably rare. Any thoughts on anything we could do to address?

@SeanTAllen SeanTAllen merged commit a87c353 into main Feb 5, 2022
@SeanTAllen SeanTAllen deleted the llvm1301 branch February 5, 2022 13:15
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Feb 5, 2022
github-actions bot pushed a commit that referenced this pull request Feb 5, 2022
github-actions bot pushed a commit that referenced this pull request Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - changed Automatically add "Changed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants