Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type of Env.root to AmbientAuth #3962

Merged
merged 11 commits into from
Jan 16, 2022
Merged

Change type of Env.root to AmbientAuth #3962

merged 11 commits into from
Jan 16, 2022

Conversation

SeanTAllen
Copy link
Member

@SeanTAllen SeanTAllen commented Jan 15, 2022

Implements RFC #65.

Closes #3557.

This is going to break a lot of stuff.

No changes needed:

  • appdirs (no PR needed)
  • reactive_streams (no PR needed)
  • regex (no PR needed)
  • crypto (no PR needed)

First round changes:

Second round changes:

  • http (needs net_ssl versioned first, this can be a 2nd round change)
  • glob (needs regex versioned first, this can be a 2nd round change)
  • valbytes (needs ponycheck versioned first, this can be a 2nd round change)
  • changelog-tool (requires peg to be versioned first)
  • rfc-tool (requires peg to be versioned first)

Third round changes:

  • http-server (needs net_ssl, valbytes, ponycheck versioned first. this is a 3rd round change)
  • ponyup (requires http to be versioned first)
  • templates (requires peg and valbytes to be versioned first)
  • github_rest_api (requires http and peg to be versioned first)

@SeanTAllen SeanTAllen requested a review from a team January 15, 2022 02:03
@SeanTAllen SeanTAllen added the changelog - changed Automatically add "Changed" CHANGELOG entry on merge label Jan 15, 2022
@ponylang-main
Copy link
Contributor

Hi @SeanTAllen,

The changelog - changed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 3962.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen SeanTAllen force-pushed the rfc-65 branch 3 times, most recently from a8b474f to 80637e9 Compare January 15, 2022 02:56
@SeanTAllen SeanTAllen merged commit c9e96c8 into main Jan 16, 2022
@SeanTAllen SeanTAllen deleted the rfc-65 branch January 16, 2022 02:51
github-actions bot pushed a commit that referenced this pull request Jan 16, 2022
github-actions bot pushed a commit that referenced this pull request Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - changed Automatically add "Changed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Change type of Env.root to AmbientAuth
4 participants