Rename FileMode.os to FileMode.u32 #3810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joe pointed out that the previous (not yet released change) that made FileMode._os could be better. u32 is a more clear name. _os didn't really matter as a name as it was private. With the functionality becoming public we need the best name possible. u32() makes perfect sense as the name as it is the filemode in a U32 representation.
Theodus
approved these changes
Jul 18, 2021
| @@ -10,10 +10,11 @@ All notable changes to the Pony compiler and standard library will be documented | |||
|
|
|||
| ### Added | |||
|
|
|||
| - Add FileMode.u32 ([PR #3809](https://github.com/ponylang/ponyc/pull/3809)) | |||
There was a problem hiding this comment.
This extra entry should probably be removed
There was a problem hiding this comment.
I dont think so, it is intentional to show that there were two PRs associated with this change.
jemc
approved these changes
Jul 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joe pointed out that the previous (not yet released change) that made
FileMode._os could be better. u32 is a more clear name. _os didn't
really matter as a name as it was private. With the functionality
becoming public we need the best name possible. u32() makes perfect
sense as the name as it is the filemode in a U32 representation.