Fix code generation for variadic FFI functions on arm64 #3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ergl
added
the
changelog - fixed
ergl
force-pushed
the
ergl/fix_variadic_codegen
branch
from
3c2e45b to
aee0b69
Compare
We need to tell LLVM about the non-optional arguments that a variadic function takes, but we were generating functions with no fixed arguments at all, even if the declaration specified them.
ergl
force-pushed
the
ergl/fix_variadic_codegen
branch
from
aee0b69 to
16b0518
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to tell LLVM about the non-optional arguments that a variadic
function takes, but we were generating functions with no fixed arguments
at all, even if the declaration specified them.