-
-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix symbol table patching for overriding default methods #3719
Conversation
`ast_replace` (potentially) copies the input AST, hence it's important to do the symbol table patching on the output AST. Otherwise the patching will happen on the wrong nodes, which leads to methods with a wrong symbol table. Fixes ponylang#3305
Hi @Trundle, The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do. Release notes are added by creating a uniquely named file in the The basic format of the release notes (using markdown) should be:
Thanks. |
This is an awesome first contribution @Trundle. Thanks. Can you add release notes? If that is done before Friday, this can go out with the release that is happening on Friday. |
Whoops I should have probably mentioned this, yes. The other tests mostly use traits and not interfaces. As the bug happens with both, I tried to be consistent with the other tests. I added some release notes, I hope that's how it works. I unfortunately forgot to add a "ci skip" though :/ |
@Trundle no need to worry about skip ci |
@Trundle release notes look good. This will go out with tomorrow's release. Thanks! |
ast_replace
(potentially) copies the input AST, hence it's importantto do the symbol table patching on the output AST. Otherwise the
patching will happen on the wrong nodes, which leads to methods with
a wrong symbol table.
Fixes #3305