Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad package names in generated documentation #3700

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

SeanTAllen
Copy link
Member

Fixes incorrect qualified path name building for relative package imports,
Instead of doing the relative path in relation to the package we were in,
it did it based on the base of the program.

So for example instead of getting

"semver/version"
or an equiv
"semver/test/version/../../version"

You'd end up with

"semver/../../version"

@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Jan 27, 2021
@SeanTAllen SeanTAllen requested a review from jemc January 27, 2021 20:36
@ponylang-main
Copy link
Contributor

Hi @SeanTAllen,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 3700.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

Fixes incorrect qualified path name building for relative package imports,
Instead of doing the relative path in relation to the package we were in,
it did it based on the base of the program.

So for example instead of getting

"semver/version"
or an equiv
"semver/test/version/../../version"

You'd end up with

"semver/../../version"
@SeanTAllen SeanTAllen force-pushed the fix-qualified-path-for-relative-packages branch from 5927e19 to d20cfe3 Compare January 27, 2021 20:40
@SeanTAllen SeanTAllen merged commit c1ad93c into master Jan 27, 2021
@SeanTAllen SeanTAllen deleted the fix-qualified-path-for-relative-packages branch January 27, 2021 21:57
github-actions bot pushed a commit that referenced this pull request Jan 27, 2021
github-actions bot pushed a commit that referenced this pull request Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants