-
-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for RISC-V #3435
Support for RISC-V #3435
Conversation
Does the exception problem only happen in debug or release mode or does it happen with both? |
@SeanTAllen that problem has magically gone away on it's own (you saw the old description before i edited it). |
That's... concerning. So if run enough we might see the problem again? |
i believe it got resolved due to the 2.5 years of changes to pony |
@dipinhora can you add CI for this as part of the PR? |
Hi @dipinhora, The changelog - added label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do. Release notes are added by creating a uniquely named file in the The basic format of the release notes (using markdown) should be:
Thanks. |
Added riscv64 CI stuff.. will probably fail cause the container image doesn't exist... |
Oh yeah. Huh. How can we get a container built. |
@SeanTAllen i tried to build and push the image to the ponylang docker repo but i don't have permissions (which makes perfect sense): $ docker push "ponylang/ponyc-ci-cross-riscv64:20220715"
The push refers to repository [docker.io/ponylang/ponyc-ci-cross-riscv64]
9fc339d915bc: Preparing
dff34515e55b: Preparing
aecbe6390165: Preparing
3fdc0d4966e3: Preparing
5e093e475d77: Preparing
259c12df0273: Waiting
9c75c22ceed8: Waiting
denied: requested access to the resource is denied i'd appreciate it if you can build/push the new image. Let me know if i need to update the image tag in this PR if it's different from |
@dipinhora i pushed |
@dipinhora one final thing before this gets merged, can you update README.md to add RiscV as a supported CPU type? 64-bit only as that is what we do CI for. Feel free to change the formatting on the supported CPU section as it is odd and hard to read. A simple listing might be better. I don't know. Really, that should be CPU + OS support listed and not separated out as we don't officially support Windows Arm for example. |
Support for riscv. All tests pass for the 64 bit target.
Instructions for testing (validated on ubuntu 20.04):