Default to statically linking llvm into ponyc #3355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this doesn't work, we can fall back to llvm-static only
|
@kulibali this doesn't touch Windows at all. That is something we should eventually discuss. |
We don't support that combo currently because we aren't building the .so when we build llvm from source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on work that @JacobChang started.
Primary change for review.
New makefile option
linkthat defaults tollvm-staticto statically link in llvm.Other options:
staticto link everything statically (formerly static=true)llvm-dynamicwhich is the old default behavior@dipin a lot of this is touching stuff that you had a hand in, if you can give all the changes a scan that would be great.
This has been through some CI already (with more to come once this PR is opened) as well as verification on Linux locally using the vendored LLVM.
Note, the also switches musl libc based nightly and releases to use
staticas the linking method.I plan on adding a CHANGELOG before this is merged.
Will close #3091.