Remove unnecessary argument to Map.sub #3275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkallos
force-pushed
the
fix/unnecessary-arg-to-map-sub
branch
from
dd22a5f to
8d81bc4
Compare
|
Can you add release notes for this breaking change to #3274, including before and after code for the change that folks need to make. Also, I think this should be under Changed not Fixed in the changelog. |
SeanTAllen
requested changes
Aug 7, 2019
rkallos
force-pushed
the
fix/unnecessary-arg-to-map-sub
branch
from
8d81bc4 to
425154d
Compare
rkallos
force-pushed
the
fix/unnecessary-arg-to-map-sub
branch
from
425154d to
b4b96cb
Compare
rkallos
changed the title
add,sub to persistent/Map
SeanTAllen
requested changes
Aug 7, 2019
|
Do not squash the two commits in this PR when merging. |
rkallos
force-pushed
the
fix/unnecessary-arg-to-map-sub
branch
from
b4b96cb to
32e449d
Compare
rkallos
changed the title
add,sub to persistent/Map
jemc
approved these changes
Aug 13, 2019
|
@SeanTAllen do you have any other concerns on this or can it be merged? |
|
@aturley yes, I'm good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map.subaccepts avalueargument that it never uses.