Fix which dtrace path check
#3229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slfritchie
added
the
changelog - fixed
|
@slfritchie the changelog bot is currently not working. can you manually add a CHANGELOG entry? |
SeanTAllen
approved these changes
Jul 17, 2019
dipinhora
reviewed
Jul 18, 2019
|
@slfritchie you need to rebase against the latest ponyc master. your code still requires pcre2 but that no longer exists in the CI images. |
Fix a GNU Make macro expansion that prevents `make use=dtrace` to work correctly on FreeBSD and Linux+SystemTap platforms. Tested on FreeBSD's GNU Make 4.2.1 and Ubuntu Xenial/16.04's GNU Make 4.1.
slfritchie
force-pushed
the
dtrace-which-fix
branch
from
d5538fc to
cf2be44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a GNU Make macro bug that prevents
make use=dtraceto workcorrectly on FreeBSD and Linux+SystemTap platforms. I don't
understand exactly why, but using
$(shell which dtrace 2> /dev/null)inside of the
USE_CHECKmacro definition always results in theempty string.
When moved outside of the macro definition, plus using
+=toupdate the value of
$(DTRACE), works correctly on bothFreeBSD's GNU Make 4.2.1 and Ubuntu Xenial/16.04's GNU Make 4.1.