Remove regex package from standard library
#3218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kulibali Can you verify I did the correct changes with the Windows build script? I assume that CI passing is "good enough" but I'm not really sure about that. |
|
We need to update a lot of CI docker images (and other docker images) once this is merged. I can handle that. |
Closed
|
I think what I will do is open a PR to remove |
The `regex` package is being removed from the standard library and moved to a new home at https://github.com/ponylang/regex/ where it will live on as an independent library. It is being removed because it has a dependency on an external library libpcre and that dependency makes creating release artifacts more difficult. At the moment we have to deal with packaging up pcre for each Linux distro etc and they all have their own methods to do so. This lead us to do a lot of work on supporting distro specific packaging. That has turned out to be too much work. We are moving to having a single glibc Linux friendly .tar.gz that can be done to install Pony. To faciliate this move, we decided that we want to remove items from the standard library that depend on external libraries like pcre. Full conversation about the decision is available in the audio of the Pony development sync July 9, 2019 audio that you can download from: https://sync-recordings.ponylang.io/r/2019_07_09.m4a
SeanTAllen
force-pushed
the
bye-bye-regex
branch
from
638f17a to
f0ae3b7
Compare
We can do this once PCRE AND LIBRESSL aren't needed
|
Ive reverted the wscript changes as I see those can't be done until both PRCE and LIBRESSL are removed. |
It seems that removing the pcre2 install loses zlib and ncurses support for some reason. Trying a couple additions to add those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
regexpackage is being removed from the standard library andmoved to a new home at https://github.com/ponylang/regex/ where it
will live on as an independent library.
It is being removed because it has a dependency on an external
library libpcre and that dependency makes creating release artifacts
more difficult.
At the moment we have to deal with packaging up pcre for each Linux
distro etc and they all have their own methods to do so. This
lead us to do a lot of work on supporting distro specific packaging.
That has turned out to be too much work. We are moving to having
a single glibc Linux friendly .tar.gz that can be done to install
Pony.
To faciliate this move, we decided that we want to remove items from
the standard library that depend on external libraries like pcre.
Full conversation about the decision is available in the audio of
the Pony development sync July 9, 2019 audio that you can download
from: https://sync-recordings.ponylang.io/r/2019_07_09.m4a