Cleanup TCPConnection GC-safety mechanism for writev buffers #3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dipinhora
added a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 9, 2019
|
@dipinhora i resolved the commit conflict with CHANGELOG but, there still appears to be a rebase against master that is needed before this can be merged. |
Prior to this commit, the TCPConnection `pending_writev` buffer had to have a secondary buffer called `_pending` to ensure that the data wouldn't get GC'd too early by the runtime. This commit removes that hack and replaces it with a slightly different hack based on the strategy used in `File` in PR ponylang#2775. The hacky part is that now we have two buffers for `writev` data. One for windows (`_pending_windows`) and one for non-windows (`_pending_posix`) to account for the difference in order of the struct between windows and posix. This, however, seems less bad than the previous hack of having the secondary buffer to ensure GC safety. resolves ponylang#2782 resolves ponylang#2779
|
@SeanTAllen rebased. |
patches11
pushed a commit
to patches11/ponyc
that referenced
this pull request
Jun 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the TCPConnection
pending_writevbuffer had tohave a secondary buffer called
_pendingto ensure that the datawouldn't get GC'd too early by the runtime.
This commit removes that hack and replaces it with a slightly different
hack based on the strategy used in
Filein PR #2775. The hacky partis that now we have two buffers for
writevdata. One for windows(
_pending_windows) and one for non-windows (_pending_posix) toaccount for the difference in order of the struct between windows
and posix. This, however, seems less bad than the previous hack of
having the secondary buffer to ensure GC safety.
resolves #2782
resolves #2779