Don't turn off Epoll OneShot when resubscribing to OneShot events #3136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dipinhora
approved these changes
Apr 25, 2019
There was a problem hiding this comment.
Duh! Not sure what I would do without you and @slfritchie finding and fixing all of my awesome bugs!
SeanTAllen
changed the title
SeanTAllen
changed the title
SeanTAllen
added
changelog - fixed
Closed
SeanTAllen
added a commit
to ponylang/lori
that referenced
this pull request
Jun 8, 2019
Pony 0.28.1 fixed a bug where Epoll OneShot events were being done using edge triggering. That fix, PR#3136 ponylang/ponyc#3136, then proceeded to break Lori. The problem? The Pony TCP runtime that Lori currently uses was creating a one shot event for connections. Lori doesn't currently support one shot at all. A recent commit to Pony master ponylang/ponyc@5f29b1b fixes the issue and allows Lori to work again. This commit brings Lori up to date with those changes so Lori can work without one shot being implemented.
SeanTAllen
added a commit
to ponylang/lori
that referenced
this pull request
Jun 8, 2019
Pony 0.28.1 fixed a bug where Epoll OneShot events were being done using edge triggering. That fix, PR#3136 ponylang/ponyc#3136, then proceeded to break Lori. The problem? The Pony TCP runtime that Lori currently uses was creating a one shot event for connections. Lori doesn't currently support one shot at all. A recent commit to Pony master ponylang/ponyc@5f29b1b fixes the issue and allows Lori to work again. This commit brings Lori up to date with those changes so Lori can work without one shot being implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the performance regression introduced in #2897. This change is really a single 1-liner, please a small change to make clear that edge triggering isn't used with one shot.