Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly specify linkage on Windows for runtime library backpressure functions. #2989

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Correctly specify linkage on Windows for runtime library backpressure functions. #2989

merged 1 commit into from
Jan 28, 2019

Conversation

chalcolith
Copy link
Member

@chalcolith chalcolith commented Jan 28, 2019 •
edited
Loading

Compiling the under_pressure example on Windows results in link errors:

under_pressure.obj : error LNK2019: unresolved external symbol pony_apply_backpressure referenced in function L__unnamed_144
under_pressure.obj : error LNK2019: unresolved external symbol pony_release_backpressure referenced in function L__unnamed_146
.\under_pressure.exe : fatal error LNK1120: 2 unresolved externals

This PR correctly specifies the linkage for these functions so they are visible to the linker.

@chalcolith chalcolith added changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge windows labels Jan 28, 2019
@SeanTAllen SeanTAllen self-requested a review January 28, 2019 03:22
@SeanTAllen
Copy link
Member

@kulibali can you add a short release notes item to this stating what it fixes that end users would notice. Like the error message perhaps?

@chalcolith
Copy link
Member Author

I've edited my initial comment.

@SeanTAllen SeanTAllen merged commit 281d651 into ponylang:master Jan 28, 2019
@SeanTAllen SeanTAllen deleted the backpressure_windows_linking branch January 28, 2019 13:21
ponylang-main added a commit that referenced this pull request Jan 28, 2019
@ponylang-main
Update CHANGELOG for PR #2989 [skip ci]
2675acd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanTAllen SeanTAllen SeanTAllen approved these changes

Assignees
No one assigned
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalcolith @SeanTAllen