Fix signed/unsigned conversion bug in siphash24 implementation #2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slfritchie
added
the
changelog - fixed
slfritchie
force-pushed
the
bug-2978
branch
2 times, most recently
from
f26ed27 to
2082485
Compare
|
Good catch! Seeing some arm failures, could it be the value needs to be different on 32bit platforms? |
|
Yup. Rather than wait for another CI cycle, I'm trying to create an AWS ARM instance to find the right unit test values for the |
|
Thanks @slfritchie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2978.
Without this patch, the values calculated by the new
_TestMapHashFuncunit test are both3830601896319666767. The unit test's values were calculated & agreed upon by two reference implementations: