Always use "binary" mode when opening files on Windows. #2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default Windows will translate `\n` to `\r\n` when writing to files, and vice versa when reading. This interacts poorly with seeking in the file first (ponylang#2707). This change makes opening files via the `files` package always use "binary" mode, which will not do any translation.
chalcolith
added
the
changelog - fixed
|
Very nice! Do you think it makes sense to have a ponytest testcase for this? Something along the lines of writing something with libebreaks to a file then reading it and assert it is the same. |
|
That wouldn't really prove anything, since Windows does the translation both for reading and writing. I think that the existing test that is failing in #2707 is sufficient to test this. |
mfelsche
approved these changes
Jun 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default Windows will translate
\nto\r\nwhen writing to files, and vice versa when reading. This interacts poorly with seeking in the file first (#2707). This change makes opening files via thefilespackage always use "binary" mode, which will not do any translation.