Fix incorrect disposable/destroyed epoll resubscribe handling #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanTAllen
added
the
changelog - fixed
mfelsche
approved these changes
Jun 12, 2018
ponylang-main
added a commit
that referenced
this pull request
Jun 12, 2018
dipinhora
added a commit
to dipinhora/ponyc
that referenced
this pull request
Jul 20, 2018
ponylang#2781 accidentally used the wrong `flags` variable. It used `flags` when it should have used `ev->flags`. This PR corrects the code to use the `ev->flags` variable. This PR also removes the check for `ASIO_DISPOSABLE` from the boolean logic because the enum value for `ASIO_DISPOSABLE` is `0` (see asio.h) and the check will always be true. This PR also adds some comments to that part of the code to clarify what is occuring and why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly this time as I messed up the boolean logic in
8b21f0a.
Closes #2684
See for initial incorrect PR
#2744