Allow user defined help string at CommandSpec.add_help() #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sleeplessy
commented
Feb 6, 2018
packages/cli/command_spec.pony
Outdated
| @@ -79,12 +80,13 @@ class CommandSpec | |||
| if _args.size() > 0 then error end | |||
| _commands.update(cmd.name(), cmd) | |||
|
|
|||
| fun ref add_help(hname: String = "help") ? => | |||
| fun ref add_help(hname: String = "help", hinfo: String = "Print help page") ? => | |||
There was a problem hiding this comment.
Maybe i should leave this default to empty
There was a problem hiding this comment.
i'd suggest to rename hinfo to descr' to accomodate to the API of OptionSpec and maybe keep a default one of display this help and exit.
There was a problem hiding this comment.
It should default to empty for this to be considered a "non-breaking change".
jemc
added
the
changelog - added
ponylang-main
added a commit
that referenced
this pull request
Feb 21, 2018
|
Thank you very much! |
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
* Allow user defined help string at CommandSpec.add_help() * Rename hinfo to descr',and leave it empty
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In package cli at command_spec.pony: