Use deferred reification during reachability analysis #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemc
approved these changes
Dec 29, 2017
|
Looks like the CI has a segfault in the codegen tests. |
Praetonus
force-pushed
the
deferred-reify-2
branch
from
9448776 to
eef648f
Compare
This change is a followup to abdcf2e. Instead of fully reifying functions during reachability analysis, the pass now uses deferred reification as needed. Functions are now fully reified one at a time during code generation, instead of all at once during reachability analysis. In the future, code generation will use deferred reification as well. This change results in a huge improvement in the memory usage of the compiler.
Praetonus
force-pushed
the
deferred-reify-2
branch
from
eef648f to
61ecb14
Compare
|
CI passed, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a followup to abdcf2e. Instead of fully reifying functions during reachability analysis, the pass now uses deferred reification as needed.
Functions are now fully reified one at a time during code generation, instead of all at once during reachability analysis. In the future, code generation will use deferred reification as well.
This change results in a huge improvement in the memory usage of the compiler.