Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ANTLR definition for char escape sequences #2440

Merged
merged 2 commits into from
Dec 29, 2017
Merged

Fix ANTLR definition for char escape sequences #2440

merged 2 commits into from
Dec 29, 2017

Conversation

mfelsche
Copy link
Contributor

unicode escapes are not allowed in character literals.

fixes #2400

[skip ci]

Praetonus
Praetonus reviewed Dec 21, 2017
View reviewed changes
Copy link
Member

@Praetonus Praetonus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the pony.g file with ponyc --antlr.

@jemc jemc changed the title fix antlr definition for char escape sequences Fix ANTLR definition for char escape sequences Dec 29, 2017
@jemc jemc added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Dec 29, 2017
@jemc jemc merged commit 912ff29 into master Dec 29, 2017
@jemc jemc deleted the antlr-escapes branch December 29, 2017 02:22
ponylang-main added a commit that referenced this pull request Dec 29, 2017
@ponylang-main
Update CHANGELOG for PR #2440 [skip ci]
22214b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Praetonus Praetonus Praetonus left review comments

Assignees
No one assigned
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Antlr lexer documentation is wrong on unicode chars
3 participants
@mfelsche @Praetonus @jemc