Fix alloc bug in String/Array trimming functions #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the trim/trim_in_place functions of Array and String incorrectly calculated the new `_alloc` value. This commit changes the logic to set `_alloc` to be the same as the new `_size` if the last byte is not included and to only included extra allocated bytes if we're including the last byte. This commit also changes how `String.from_cpointer` calculates the `_alloc` value as it was incorrectly adding a byte when it shouldn't have been (this was likely due to an assumption of a null terminator being present that doesn't hold any longer). Tests have also been enhanced to prevent regressions.
dipinhora
added
the
changelog - fixed
|
NOTE: These issues were discovered while working on #2337 and that PR is not safe to implement until these bugs are fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the trim/trim_in_place functions of Array
and String incorrectly calculated the new
_allocvalue.This commit changes the logic to set
_allocto be the sameas the new
_sizeif the last byte is not included and toonly included extra allocated bytes if we're including the
last byte.
This commit also changes how
String.from_cpointercalculatesthe
_allocvalue as it was incorrectly adding a byte when itshouldn't have been (this was likely due to an assumption of a
null terminator being present that doesn't hold any longer).
Tests have also been enhanced to prevent regressions.