DragonFly BSD 4.8 support #2183
Conversation
src/common/pony/detail/atomics.h
Outdated
| # include <stdalign.h> | ||
| #endif | ||
|
|
||
| #include <platform.h> |
There was a problem hiding this comment.
this is needed because dragonfly uses GCC but it doesn't use glibc so there's not <features.h> as referenced below. perhaps there is a better way to do this?
There was a problem hiding this comment.
The problem here is that platform.h is a private header while atomics.h is a public one. Depending on how much of platform.h is needed, I'd suggest to either copy/paste the relevant parts into atomics.h or to make a new platform_public.h file which would be included by both platform.h and atomics.h, and installed alongside of pony.h and atomics.h.
There was a problem hiding this comment.
In fact I think we don't even need to include features.h anymore. This was needed for the __GNUC_PREREQ macro but we stopped using it in the Alpine port.
There was a problem hiding this comment.
@Praetonus let me try removing entirely and lets see what happens.
There was a problem hiding this comment.
Nice catch Benoit. We didn't need features.h anymore. I've removed it entirely along with the platform.h inclusion.
| " $extra $ifdefnot $noseq($flag linux $ifdefor $flag osx $ifdefor\n" | ||
| " $flag freebsd) then\n" | ||
| " $flag bsd) then\n" |
There was a problem hiding this comment.
should freebsd and dragonfly be in this as well? i dont think so...
|
@Theodus can you check to make sure this still builds and passes on FreeBSD? |
Benoit says we no longer need.
|
thanks @Theodus. when this is in "final shape", i'm going to ask you for one last test. |
Makefile
Outdated
| @@ -168,6 +173,10 @@ ifeq ($(OSTYPE),osx) | |||
| ALL_CXXFLAGS += -stdlib=libc++ -mmacosx-version-min=10.8 | |||
| endif | |||
|
|
|||
| ifeq ($(UNAME_S),DragonFly) | |||
| LINKER_FLAGS += -L /usr/local/lib | |||
There was a problem hiding this comment.
/usr/local/lib is explicitly required for DragonFly.
Is there any reason to not make this a default path for every OS?
There was a problem hiding this comment.
Sounds right to me (at least, for every non-Windows OS 😉).
|
This is now complete and will build on DragonFly. I'd be good with squashing this down if there are no changes and getting it on master. I'm leaving for feedback at sync (I do have a couple open questions) and then one final whirl from @Theodus on FreeBSD. |
SeanTAllen
added
the
changelog - added
|
Works on FreeBSD 11.0-RELEASE-p1 |
|
I ll make the Makfile change and then squash this. |
Merged change: d59c185
Merged change: d59c185
These changes serve no real purpose in gbenchmark where there are no differences between FREE BSD and DragonFly BSD. I didn't realize that when I created PR ponylang#2573 "Update gbenchmark" and merged in the gbenchmark changes from PR ponylang#2183. This reverts back to just using BENCHMARK_OS_FREEBSD in lib/gbenchmark and thus a few less differences between lib/gbenchmark and google/benchmark.
I got bored. I did this.
In many ways, FreeBSD and DragonFly are the same in that they are BSD based. However, they are entirely different OSes in a way that Debian and Arch are not. From a "platform" support perspective, I ended up going with defining bsd/freebsd/dragonfly. I'm not sure this is the correct long term thing. I'd want to implement OpenBSD and/or NetBSD before drawing any conclusions.
I'm opening this to get feedback on where this is at so far.