Make actor continuations a build time option #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Encore project uses the Pony runtime and has implemented continuations for actors. There's a small amount of code in the Pony runtime to support these continuations. It's a fairly unobtrusive bit of code except for one small point. There's a check for continuation in a hot path when actors are handling messages. This commit makes actor continuation support a compile time option. To get previous actor continuation support, USE_ACTOR_CONTINUATIONS should be defined. Support for this exists in the Makefile as a "use" directive.
SeanTAllen
added
the
changelog - changed
sylvanc
approved these changes
Aug 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Encore project uses the Pony runtime and has implemented
continuations for actors. There's a small amount of code in the Pony
runtime to support these continuations. It's a fairly unobtrusive bit of
code except for one small point. There's a check for continuation in a
hot path when actors are handling messages. This commit makes actor
continuation support a compile time option.
To get previous actor continuation support, USE_ACTOR_CONTINUATIONS
should be defined. Support for this exists in the Makefile as a "use"
directive.